On Wed, Oct 23, 2019 at 08:53:02AM +0530, Viresh Kumar wrote: > On 22-10-19, 17:09, Nathan Chancellor wrote: > > When building with Clang + -Wtautological-pointer-compare: > > > > drivers/cpufreq/s3c64xx-cpufreq.c:152:6: warning: comparison of array > > 's3c64xx_freq_table' equal to a null pointer is always false > > [-Wtautological-pointer-compare] > > if (s3c64xx_freq_table == NULL) { > > ^~~~~~~~~~~~~~~~~~ ~~~~ > > 1 warning generated. > > > > The definition of s3c64xx_freq_table is surrounded by an ifdef > > directive for CONFIG_CPU_S3C6410, which is always true for this driver > > because it depends on it in drivers/cpufreq/Kconfig.arm (and if it > > weren't, there would be a build error because s3c64xx_freq_table would > > not be a defined symbol).
> +broonie, who wrote this patch to see his views on why he kept it like > this. The driver should also have supported s3c6400 as well.
signature.asc
Description: PGP signature