On Tue, 2007-10-02 at 18:09 -0400, Bill Davidsen wrote: > Mel Gorman wrote: > > On (02/10/07 14:15), Ingo Molnar didst pronounce: > >> * Mel Gorman <[EMAIL PROTECTED]> wrote: > >> > >>> Dirt. Booting with "profile=sleep,2" is broken in 2.6.23-rc9 and > >>> 2.6.23-rc8 but working in 2.6.22. I was checking it out as part of a > >>> discussion in another thread and noticed it broken in -mm as well > >>> (2.6.23-rc8-mm2). Bisect is in progress but suggestions as to the > >>> prime candidates are welcome or preferably, pointing out that I'm an > >>> idiot because I missed twiddling some config change. > >> Mel, does the patch below fix this bug for you? (Note: you will need to > >> enable CONFIG_SCHEDSTATS=y too.) > >> > > > > Nice one Ingo - got it first try. The problem commit was > > dd41f596cda0d7d6e4a8b139ffdfabcefdd46528 and it's clear that the code > > removed > > in this commit is put back by this latest patch. When applied, > > profile=sleep > > works as long as CONFIG_SCHEDSTAT is set. > > > And if it isn't set? I can easily see building a new kernel with stats > off and forgetting to change the boot options. >
If CONFIG_SCHEDSTAT is off and profile=sleep is set, you see with Ingo's patch and readprofile; 0 *unknown* 0 total 0.0000 That is a tad confusing hence my follow-up patch which would say "/proc/profile" doesn't exist when readprofile is used and the warning in dmesg. -- Mel Gorman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/