Re: [RFC PATCH v11 6/9] media: tegra: Add Tegra210 Video input driver

[Dmitry Osipenko]

30.04.2020 01:00, Sowjanya Komatineni пишет:
> +static int chan_capture_kthread_finish(void *data)
> +{
> +     struct tegra_vi_channel *chan = data;
> +     struct tegra_channel_buffer *buf;
> +
> +     set_freezable();
> +
> +     while (1) {
> +             try_to_freeze();

I guess it won't be great to freeze in the middle of a capture process, so:
                if (list_empty(&chan->done))
                        try_to_freeze();

> +             wait_event_interruptible(chan->done_wait,
> +                                      !list_empty(&chan->done) ||
> +                                      kthread_should_stop());
> +
> +             /* dequeue buffers and finish capture */
> +             buf = dequeue_buf_done(chan);
> +             while (buf) {
> +                     tegra_channel_capture_done(chan, buf);
> +                     buf = dequeue_buf_done(chan);
> +             }
> +
> +             if (kthread_should_stop())
> +                     break;
> +     }
> +
> +     return 0;
> +}