On Thu, Apr 30, 2020 at 02:57:00PM +0300, Priit Laes wrote: > Now that driver supports syscon-based regmap access, document also the > devicetree binding. > > Signed-off-by: Priit Laes <pl...@plaes.org> > --- > .../bindings/net/allwinner,sun7i-a20-gmac.yaml | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml > b/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml > index 703d0d886884..c41d7c598c19 100644 > --- a/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml > +++ b/Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml > @@ -29,17 +29,26 @@ properties: > clocks: > items: > - description: GMAC main clock > + > + # Deprecated > - description: TX clock > > clock-names: > items: > - const: stmmaceth > + > + # Deprecated > - const: allwinner_gmac_tx
That would be deprecated: true Also, you still require to have two clocks here? > > phy-supply: > description: > PHY regulator > > + syscon: > + $ref: /schemas/types.yaml#definitions/phandle > + description: > + Phandle to the device containing the GMAC clock register > + > required: > - compatible > - reg > @@ -48,6 +57,7 @@ required: > - clocks > - clock-names > - phy-mode > + - syscon You can't do that though, this changes the binding in a non-backward compatible way I guess you could add an if clause to require it if clocks has a single member. Maxime
signature.asc
Description: PGP signature
