On Wed, Oct 03, 2007 at 05:56:45AM +0300, Heikki Orsila wrote:
> On Tue, Oct 02, 2007 at 07:50:07PM -0700, [EMAIL PROTECTED] wrote:
> > +struct mthca_reg_mr {
> > + __u32 mr_attrs;
> > +#define MTHCA_MR_DMAFLUSH 0x1 /* flush in-flight DMA on a write to
> > + * memory region */
> > + __u32 reserved;
> > +};
>
> Seems like a very odd place to #define something new..
>
Lots of drivers do that - #define flags or whatever near the
variable to which they apply. Didn't see any examples in the
mthca driver though, so maybe it's setting a precedent there.
If the maintainer objects, I'll move it.
--
Arthur
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
