On 2020-04-29 00:46, Luis Chamberlain wrote:
> +static struct dentry *blk_trace_debugfs_dir(struct blk_user_trace_setup
> *buts,
> + struct blk_trace *bt)
> +{
> + struct dentry *dir = NULL;
> +
> + dir = debugfs_lookup(buts->name, blk_debugfs_root);
> + if (!dir)
> + bt->dir = dir = debugfs_create_dir(buts->name,
> blk_debugfs_root);
> +
> + return dir;
> +}Initializing 'dir' is not necessary since the first statement overwrites 'dir'. Anyway: Reviewed-by: Bart Van Assche <bvanass...@acm.org>
