On Sat, May 02, 2020 at 11:55:01AM +0800, Tiezhu Yang wrote: > It is better to show the result before loongson3-llsc-check exit, > otherwise we can see nothing if the return status is EXIT_SUCCESS, > it seems confusing. > > E.g. without this patch: > > [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux > [loongson@localhost tools]$ > > With this patch: > > [loongson@localhost tools]$ ./loongson3-llsc-check ../../../vmlinux > loongson3-llsc-check returns success > [loongson@localhost tools]$ > > Signed-off-by: Tiezhu Yang <yangtie...@loongson.cn> > --- > > v2: > - move "returns" after "loongson3-llsc-check" suggested by Sergei > > arch/mips/tools/loongson3-llsc-check.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/tools/loongson3-llsc-check.c > b/arch/mips/tools/loongson3-llsc-check.c > index 0ebddd0..bdbc7b4 100644 > --- a/arch/mips/tools/loongson3-llsc-check.c > +++ b/arch/mips/tools/loongson3-llsc-check.c > @@ -303,5 +303,7 @@ int main(int argc, char *argv[]) > out_close: > close(vmlinux_fd); > out_ret: > + fprintf(stdout, "loongson3-llsc-check returns %s\n", > + status ? "failure" : "success"); > return status; > } > -- > 2.1.0
I've applied your first version, please rebase to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
