Hi Eric,
On 02/05/2020 20:24, Eric Biggers wrote:
From: Eric Biggers <ebigg...@google.com>
In preparation for naming the SHA-1 stuff in <linux/cryptohash.h>
properly and moving it to a more appropriate header, fix the HMAC-SHA256
code in mptcp_crypto_hmac_sha() to use SHA256_BLOCK_SIZE instead of
"SHA_MESSAGE_BYTES" which is actually the SHA-1 block size.
(Fortunately these are both 64 bytes, so this wasn't a "real" bug...)
Good catch! I guess it was left when switching from SHA-1 to SHA-256 in
65492c5a6ab5 (mptcp: move from sha1 (v0) to sha256 (v1)).
For MPTCP related code, it looks good to me, thank you for this!
Reviewed-by: Matthieu Baerts <matthieu.bae...@tessares.net>
--
Matthieu Baerts | R&D Engineer
matthieu.bae...@tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
