> The check doesn't support below formats and it will emit diagnostics info for 
> them:
…
> Fixes: ba35f8588f47 (“ipvlan: Defer multicast / broadcast processing to a 
> work-queue”)
…
> Fixes: 03f6fc6de919 ('ASoC: rt5682: Add the soundwire support')

Will the tolerance (and support) grow for such quotation character alternatives?


> Note: this patch also fixes double quotation mark issue for normal git
>       commit description, and now it supports double quotation mark in
>       title line, for example:
>       Commit e33e2241e272 ("Revert "cfg80211: Use 5MHz bandwidth by default
>       when checking usable channels"")

Do you care to achieve a safe data format description also for this use case?


> Note: this patch also adds diagnostics info support for normal git commit
>       description format check.

Does this information indicate a need to split possible changes into
separate update steps?


> +                             $diagnostics .= "Missing a pair of parentheses 
> '()' or a pair of double quotation marks (\"\").\n";

Can such a message trigger any more thoughts and development ideas?


> +                                     $diagnostics .= "The title is too 
> abbreviated, at least half of orignial commit title is necessary.\n";

* Please avoid a typo in this message.

* Which formula do you propose for the length calculation?

Regards,
Markus

Reply via email to