On Sun, May 03, 2020 at 03:51:39PM +0200, Markus Elfring wrote:
>
>
> …
> > + $diagnostics .= "The title is too
> > abbreviated, at least half of orignial commit title is necessary.\n";
>
> Will the word “original” be more appropriate here?
> (Why did you not integrate my previous patch review comment?)
Sorry, I miss it.
This version patch has indentation issue, I will fix the typo
with the indentation issue in next version (v6).
Thanks.
>
>
> …
> > + "Please use git commit description style
> > '$prefix <$sha1_length_min+ chars of sha1> (\"<$title>\")' - ie:
> > '${init_char}" . substr($prefix, 1) .
> > + " $id (\"$description\")'\n" .
> > $diagnostics . $herecurr);
>
> Can error diagnostics become multi-line?
The length of "$description" is unknown, it is difficult to
cook the error message into pretty format with any length of
"$description", so let's keep it in current way.
Thanks.
