On 2020/5/6 1:25, Matthew Wilcox wrote: > On Tue, May 05, 2020 at 07:55:41PM +0800, Zhen Lei wrote: >> +++ b/mm/swapfile.c >> @@ -177,8 +177,8 @@ static int discard_swap(struct swap_info_struct *si) >> >> /* Do not discard the swap header page! */ >> se = first_se(si); >> - start_block = (se->start_block + 1) << (PAGE_SHIFT - 9); >> - nr_blocks = ((sector_t)se->nr_pages - 1) << (PAGE_SHIFT - 9); >> + start_block = (se->start_block + 1) << SECTORS_PER_PAGE_SHIFT; >> + nr_blocks = ((sector_t)se->nr_pages - 1) << SECTORS_PER_PAGE_SHIFT; > > Thinking about this some more, wouldn't this look better? > > start_block = page_sectors(se->start_block + 1); > nr_block = page_sectors(se->nr_pages - 1); > OKļ¼That's fine, it's clearer. And in this way, there won't be more than 80 columns. > > . >
- [PATCH 0/4] eliminate SECTOR related magic numbers a... Zhen Lei
- [PATCH 1/4] block: Move SECTORS_PER_PAGE and SE... Zhen Lei
- Re: [PATCH 1/4] block: Move SECTORS_PER_PAG... Matthew Wilcox
- Re: [PATCH 1/4] block: Move SECTORS_PER... Leizhen (ThunderTown)
- [PATCH 2/4] mm/swap: use SECTORS_PER_PAGE_SHIFT... Zhen Lei
- Re: [PATCH 2/4] mm/swap: use SECTORS_PER_PA... Matthew Wilcox
- Re: [PATCH 2/4] mm/swap: use SECTORS_PE... Leizhen (ThunderTown)
- Re: [PATCH 2/4] mm/swap: use SECTOR... Leizhen (ThunderTown)
- Re: [PATCH 2/4] mm/swap: use S... Leizhen (ThunderTown)
- [PATCH 3/4] block: use SECTORS_PER_PAGE_SHIFT a... Zhen Lei
- [PATCH 4/4] mtd: eliminate SECTOR related magic... Zhen Lei
- Re: [PATCH 0/4] eliminate SECTOR related magic ... antlists
- Re: [PATCH 0/4] eliminate SECTOR related ma... Matthew Wilcox