Re: [patch V4 part 1 04/36] sched: Make scheduler_ipi inline

[Alexandre Chartre]

On 5/5/20 3:16 PM, Thomas Gleixner wrote:

Now that the scheduler IPI is trivial and simple again there is no point to
have the little function out of line. This simplifies the effort of
constraining the instrumentation nicely.

Signed-off-by: Thomas Gleixner <t...@linutronix.de>
---
  include/linux/sched.h |   10 +++++++++-
  kernel/sched/core.c   |   10 ----------
  2 files changed, 9 insertions(+), 11 deletions(-)

Reviewed-by: Alexandre Chartre <alexandre.char...@oracle.com>

alex.

--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1719,7 +1719,15 @@ extern char *__get_task_comm(char *to, s
  })

#ifdef CONFIG_SMP

-void scheduler_ipi(void);
+static __always_inline void scheduler_ipi(void)
+{
+       /*
+        * Fold TIF_NEED_RESCHED into the preempt_count; anybody setting
+        * TIF_NEED_RESCHED remotely (for the first time) will also send
+        * this IPI.
+        */
+       preempt_fold_need_resched();
+}
  extern unsigned long wait_task_inactive(struct task_struct *, long 
match_state);
  #else
  static inline void scheduler_ipi(void) { }
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2312,16 +2312,6 @@ static void wake_csd_func(void *info)
        sched_ttwu_pending();
  }

-void scheduler_ipi(void)

-{
-       /*
-        * Fold TIF_NEED_RESCHED into the preempt_count; anybody setting
-        * TIF_NEED_RESCHED remotely (for the first time) will also send
-        * this IPI.
-        */
-       preempt_fold_need_resched();
-}
-
  static void ttwu_queue_remote(struct task_struct *p, int cpu, int wake_flags)
  {
        struct rq *rq = cpu_rq(cpu);