Em Thu, May 07, 2020 at 11:28:57AM -0500, Paul A. Clarke escreveu: > From: "Paul A. Clarke" <[email protected]> > > The metric definition is too long for the current value of EXPR_MAX_OTHER. > Increase the value EXPR_MAX_OTHER sufficiently to allow > 'lsu_other_stall_cpi' to build properly.
I already have a patch from Ian that bumps this further: [acme@five perf]$ git log -p tools/perf/util/expr.h commit 26d3350db3e4668c1b1ff7f81c419afe71a2e8d9 Author: Ian Rogers <[email protected]> Date: Fri May 1 10:33:26 2020 -0700 perf expr: Increase max other Large metrics such as Branch_Misprediction_Cost_SMT on x86 broadwell need more space. Signed-off-by: Ian Rogers <[email protected]> Acked-by: Jiri Olsa <[email protected]> Cc: Adrian Hunter <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Haiyan Song <[email protected]> Cc: Jin Yao <[email protected]> Cc: John Garry <[email protected]> Cc: Kajol Jain <[email protected]> Cc: Kan Liang <[email protected]> Cc: Leo Yan <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Paul Clarke <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Ravi Bangoria <[email protected]> Cc: Song Liu <[email protected]> Cc: Stephane Eranian <[email protected]> Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h index 87d627bb699b..40fc452b0f2b 100644 --- a/tools/perf/util/expr.h +++ b/tools/perf/util/expr.h @@ -2,7 +2,7 @@ #ifndef PARSE_CTX_H #define PARSE_CTX_H 1 -#define EXPR_MAX_OTHER 20 +#define EXPR_MAX_OTHER 64 #define MAX_PARSE_ID EXPR_MAX_OTHER struct expr_parse_id { > Before: > -- > $ perf list | grep lsu_other > lsu_other_stall_cpi > # perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1 > Cannot find metric or group `lsu_other_stall_cpi' > > Usage: perf stat [<options>] [<command>] > > -M, --metrics <metric/metric group list> > monitor specified metrics or metric groups > (separated by ,) > -- > > After: > -- > # perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1 > > Performance counter stats for 'system wide': > > 438,086,889 pm_cmplu_stall_lsu # 1.74 > lsu_other_stall_cpi > [...] > -- > > Signed-off-by: Paul A. Clarke <[email protected]> > --- > tools/perf/util/expr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h > index 87d627bb699b..a0991959cca4 100644 > --- a/tools/perf/util/expr.h > +++ b/tools/perf/util/expr.h > @@ -2,7 +2,7 @@ > #ifndef PARSE_CTX_H > #define PARSE_CTX_H 1 > > -#define EXPR_MAX_OTHER 20 > +#define EXPR_MAX_OTHER 28 > #define MAX_PARSE_ID EXPR_MAX_OTHER > > struct expr_parse_id { > -- > 2.18.2 > -- - Arnaldo
