It is more efficient to use kmemdup_nul() if the size is known exactly.

The doc in kernel:
"Note: Use kmemdup_nul() instead if the size is known exactly."

Signed-off-by: Chen Zhou <chenzho...@huawei.com>
---
 drivers/nvme/target/configfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index 58cabd7b6fc5..9894668a40e7 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -327,7 +327,7 @@ static ssize_t nvmet_ns_device_path_store(struct 
config_item *item,
 
        kfree(ns->device_path);
        ret = -ENOMEM;
-       ns->device_path = kstrndup(page, len, GFP_KERNEL);
+       ns->device_path = kmemdup_nul(page, len, GFP_KERNEL);
        if (!ns->device_path)
                goto out_unlock;
 
@@ -963,7 +963,7 @@ static ssize_t nvmet_subsys_attr_model_store(struct 
config_item *item,
                        return -EINVAL;
        }
 
-       new_model_number = kstrndup(page, len, GFP_KERNEL);
+       new_model_number = kmemdup_nul(page, len, GFP_KERNEL);
        if (!new_model_number)
                return -ENOMEM;
 
-- 
2.20.1

Reply via email to