Since the TX and RX DMA-slave config structures are declared on the
stack and only a part of their fields is initialized further in the
prepare Tx/Rx methods, the next dmaengine_slave_config() calls may
randomly perform an incorrect DMA channels setup depending on the
stack initial values. Lets fix this by zeroing the config-structures
before using them.

Co-developed-by: Georgy Vlasov <georgy.vla...@baikalelectronics.ru>
Signed-off-by: Georgy Vlasov <georgy.vla...@baikalelectronics.ru>
Signed-off-by: Serge Semin <sergey.se...@baikalelectronics.ru>
Cc: Ramil Zaripov <ramil.zari...@baikalelectronics.ru>
Cc: Alexey Malahov <alexey.mala...@baikalelectronics.ru>
Cc: Thomas Bogendoerfer <tsbog...@alpha.franken.de>
Cc: Paul Burton <paulbur...@kernel.org>
Cc: Ralf Baechle <r...@linux-mips.org>
Cc: Arnd Bergmann <a...@arndb.de>
Cc: Allison Randal <alli...@lohutok.net>
Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Cc: Gareth Williams <gareth.williams...@renesas.com>
Cc: Rob Herring <robh...@kernel.org>
Cc: linux-m...@vger.kernel.org
Cc: devicet...@vger.kernel.org
---
 drivers/spi/spi-dw-dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-dw-dma.c b/drivers/spi/spi-dw-dma.c
index d89a00fb705e..3802d2cafe91 100644
--- a/drivers/spi/spi-dw-dma.c
+++ b/drivers/spi/spi-dw-dma.c
@@ -166,7 +166,7 @@ static void dw_spi_dma_tx_done(void *arg)
 static struct dma_async_tx_descriptor *dw_spi_dma_prepare_tx(struct dw_spi 
*dws,
                struct spi_transfer *xfer)
 {
-       struct dma_slave_config txconf;
+       struct dma_slave_config txconf = {0};
        struct dma_async_tx_descriptor *txdesc;
 
        if (!xfer->tx_buf)
@@ -238,7 +238,7 @@ static void dw_spi_dma_rx_done(void *arg)
 static struct dma_async_tx_descriptor *dw_spi_dma_prepare_rx(struct dw_spi 
*dws,
                struct spi_transfer *xfer)
 {
-       struct dma_slave_config rxconf;
+       struct dma_slave_config rxconf = {0};
        struct dma_async_tx_descriptor *rxdesc;
 
        if (!xfer->rx_buf)
-- 
2.25.1

Reply via email to