On Wed, May 06, 2020 at 08:42:36PM +0300, [email protected] wrote: > From: Serge Semin <[email protected]> > > Commit 07d69579e7fe ("MIPS: Don't register r4k sched clock when > CPUFREQ enabled") disabled the r4k-clock usage for scheduler ticks > counting due to the scheduler being non-tolerant for unstable > clocks sources. For the same reason the clock should be used > in the system clocksource framework only as a last resort if CPU > frequency may change. > > Signed-off-by: Serge Semin <[email protected]> > Cc: Alexey Malahov <[email protected]> > Cc: Thomas Bogendoerfer <[email protected]> > Cc: Paul Burton <[email protected]> > Cc: Ralf Baechle <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > arch/mips/kernel/csrc-r4k.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/kernel/csrc-r4k.c b/arch/mips/kernel/csrc-r4k.c > index 437dda64fd7a..d81fb374f477 100644 > --- a/arch/mips/kernel/csrc-r4k.c > +++ b/arch/mips/kernel/csrc-r4k.c > @@ -71,7 +71,11 @@ int __init init_r4k_clocksource(void) > return -ENXIO; > > /* Calculate a somewhat reasonable rating value */ > +#ifndef CONFIG_CPU_FREQ > clocksource_mips.rating = 200 + mips_hpt_frequency / 10000000; > +#else > + clocksource_mips.rating = 99; > +#endif
I dislike this patch. Assuming you have an other clocksource, why not simply disable csrc-r4k, if CPU_FREQ is enabled ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
