On Fri, May 08, 2020 at 10:53:41AM -0500, Josh Poimboeuf wrote: > On Fri, May 08, 2020 at 08:06:34PM +0800, Samuel Zou wrote: > > Fix the following sparse warning: > > > > kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs' > > was not declared. Should it be static? > > Yes, it should :-) > > So instead of the question, the patch description should probably state > that it should be static because its only caller is in the file.
... and it probably should also have a Fixes tag which references the commit which introduced this issue. > With that change: > > Acked-by: Josh Poimboeuf <[email protected]> -- Josh
