On Sat, 9 May 2020 08:14:24 +0900 Masami Hiramatsu <[email protected]> wrote:
> On Fri, 8 May 2020 11:13:49 -0400 > Steven Rostedt <[email protected]> wrote: > > > From: "Steven Rostedt (VMware)" <[email protected]> > > > > The return of apply_xbc() returns the result of the last write() call, which > > is not what is expected. It should only return zero on success. > > > > Link: https://lore.kernel.org/r/20200508093059.GF9365@kadam > > > > Thanks for fixing! > > Acked-by: Masami Hiramatsu <[email protected]> > Oh, and tested too. --- ... test case 40 (samples/good-tree.bconf)... Apply samples/good-tree.bconf to ./initrd-tNhd Number of nodes: 16 Size: 136 bytes Checksum: 9171 [OK] All tests passed --- Tested-by: Masami Hiramatsu <[email protected]> BTW, I might better add a test summary to the test script (and move it into kselftest?) Thank you, > > > Fixes: 8842604446d1 ("tools/bootconfig: Fix resource leak in apply_xbc()") > > Reported-by: Dan Carpenter <[email protected]> > > Signed-off-by: Steven Rostedt (VMware) <[email protected]> > > --- > > tools/bootconfig/main.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c > > index 001076c51712..0efaf45f7367 100644 > > --- a/tools/bootconfig/main.c > > +++ b/tools/bootconfig/main.c > > @@ -337,6 +337,7 @@ int apply_xbc(const char *path, const char *xbc_path) > > pr_err("Failed to apply a boot config magic: %d\n", ret); > > goto out; > > } > > + ret = 0; > > out: > > close(fd); > > free(data); > > -- > > 2.20.1 > > > > > -- > Masami Hiramatsu <[email protected]> -- Masami Hiramatsu <[email protected]>
