On Sat, Oct 06, 2007 at 08:19:11PM +0200, Arnd Bergmann wrote: > As found by sparse, a user space pointer is assigned to a kernel > data structure while calling other code with set_fs(KERNEL_DS), > which could lead to leaking kernel data if that pointer is > ever accessed. > > I could not find any place in the floppy drivers that actually > uses that pointer, but assigning it to an empty string is > a safer choice and gets rid of the sparse warning.
FWIW, I'd kill kmalloc(), switched to compat_alloc_user_space() and copy_in_user() / get_user()+put_user(). And kill set_fs() around that sys_ioctl()... Separate from the rest of this series, though. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
