Hi Gwendal, Thank you for the patch! Yet something to improve:
[auto build test ERROR on iio/togreg] [also build test ERROR on chrome-platform-linux/for-next linus/master v5.7-rc5 next-20200508] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Gwendal-Grignou/iio-cros_ec-Add-support-for-RGB-light-sensor/20200507-074251 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value] #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:51:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' CROS_EC_LIGHT_RGB_SPACE_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/iio/light/cros_ec_light_prox.c:39:38: error: initializer element is >> not constant #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:51:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' CROS_EC_LIGHT_RGB_SPACE_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/light/cros_ec_light_prox.c:39:38: note: (near initialization for 'cros_ec_light_prox_bitmasks[3]') #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:51:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' CROS_EC_LIGHT_RGB_SPACE_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value] #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:52:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' CROS_EC_LIGHT_RGB_SPACE_MASK | CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/iio/light/cros_ec_light_prox.c:39:38: error: initializer element is >> not constant #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:52:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' CROS_EC_LIGHT_RGB_SPACE_MASK | CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/light/cros_ec_light_prox.c:39:38: note: (near initialization for 'cros_ec_light_prox_bitmasks[4]') #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:52:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' CROS_EC_LIGHT_RGB_SPACE_MASK | CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/light/cros_ec_light_prox.c: In function 'cros_ec_light_capture': drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value] #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:404:19: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' (scan_mask & CROS_EC_LIGHT_RGB_SPACE_MASK)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/iio/light/cros_ec_light_prox.c: In function 'cros_ec_light_prox_update_scan_mode': drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value] #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) ^ drivers/iio/light/cros_ec_light_prox.c:434:24: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK' else if (*scan_mask & CROS_EC_LIGHT_RGB_SPACE_MASK) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +39 drivers/iio/light/cros_ec_light_prox.c 23 24 /* 25 * We may present up to 7 channels: 26 * 27 * +-----+-----+-----+-----+-----+-----+-----+ 28 * |Clear| X | Y | Z | RED |BLUE |GREEN| 29 * |Prox | | | | | | | 30 * +-----+-----+-----+-----+-----+-----+-----+ 31 * 32 * Prox[imity] is presented by proximity sensors. 33 * The clear channel is supported by single and color light sensors. 34 * Color light sensor either reports color information in the RGB space or 35 * the CIE 1931 XYZ (XYZ) color space. 36 */ 37 #define CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK GENMASK(0, 0) 38 #define CROS_EC_LIGHT_XYZ_SPACE_MASK GENMASK(3, 1) > 39 #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4) 40 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
