On Mon, 8 Oct 2007 17:33:53 +0200 "Vegard Nossum" <[EMAIL PROTECTED]> wrote:
> On 10/8/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > On Sun, 7 Oct 2007 16:50:49 -0500 > > Rob Landley <[EMAIL PROTECTED]> wrote: > > > > > On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: > > > > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > > I made it about halfway through the patch and the only compile time > > > filtering > > > I found was: > > > > > > --- a/drivers/md/md.c > > > +++ b/drivers/md/md.c > > > @@ -62,7 +62,10 @@ > > > #define MdpMinorShift 6 > > > > > > #define DEBUG 0 > > > -#define dprintk(x...) ((void)(DEBUG && printk(x))) > > > +#define dprintk(x...)\ > > > +if(DEBUG) {\ > > > + printk(x);\ > > > +} > > > > > > If you say it does, I'll take your word for it, but there's so much churn > > > in > > > there I didn't find it before my interest ran out... > > > > > > > BTW that change might actually break code (dangling else problems). > > The original way was safer. > > Yep, thanks. I think containing it in do {} while(0) should fix, though, no? > > Vegard The correct fix is to just replace dprintk() with pr_debug() -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/