> From: Kai-Heng Feng <kai.heng.f...@canonical.com> > Sent: Monday, May 4, 2020 9:02 PM > To: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: Kai-Heng Feng <kai.heng.f...@canonical.com>; Brown, Aaron F > <aaron.f.br...@intel.com>; David S. Miller <da...@davemloft.net>; > moderated list:INTEL ETHERNET DRIVERS <intel-wired-...@lists.osuosl.org>; > open list:NETWORKING DRIVERS <net...@vger.kernel.org>; open list <linux- > ker...@vger.kernel.org> > Subject: [PATCH v2] igb: Report speed and duplex as unknown when device is > runtime suspended > > igb device gets runtime suspended when there's no link partner. We can't > get correct speed under that state: > $ cat /sys/class/net/enp3s0/speed > 1000 > > In addition to that, an error can also be spotted in dmesg: > [ 385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost > > Since device can only be runtime suspended when there's no link partner, > we can skip reading register and let the following logic set speed and > duplex with correct status. > > The more generic approach will be wrap get_link_ksettings() with begin() > and complete() callbacks. However, for this particular issue, begin() > calls igb_runtime_resume() , which tries to rtnl_lock() while the lock > is already hold by upper ethtool layer. > > So let's take this approach until the igb_runtime_resume() no longer > needs to hold rtnl_lock. > > Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > Cc: Aaron Brown <aaron.f.br...@intel.com> > Suggested-by: Alexander Duyck <alexander.du...@gmail.com> > Signed-off-by: Kai-Heng Feng <kai.heng.f...@canonical.com> > --- > v2: > - Don't early return the routine so other info can be set. > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Tested-by: Aaron Brown <aaron.f.br...@intel.com>
