On Wed, May 13, 2020 at 01:05:57AM +0200, Ondřej Jirman wrote: > On Tue, May 12, 2020 at 03:52:12PM -0700, Dmitry Torokhov wrote: > > On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote: > > > It is possible to turn the motor on/off just by enabling/disabling > > > the vcc-supply. > > > > > > Signed-off-by: Ondrej Jirman <[email protected]> > > > Acked-by: Rob Herring <[email protected]> > > > --- > > > Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > > > b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > > > index 2384465eaa19..c700b640bd53 100644 > > > --- a/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > > > +++ b/Documentation/devicetree/bindings/input/gpio-vibrator.yaml > > > @@ -24,7 +24,6 @@ properties: > > > > > > required: > > > - compatible > > > - - enable-gpios > > > > Hmm we need at least one of the 2 (gpio and supply). Should we encode it > > in the binding? > > Not sure how to encode either one or the other property being required, but > not both at once. > > Maybe I can add a supply-vibrator compatible to the driver and binding and > make requirements dependent on the compatible?
Rob is our bindings overlord... I'll defer to him here. Thanks. -- Dmitry
