Not only is it in the bad order (rdp->nocb_lock should be unlocked after rnp) but it's also dead code as we are in the !offloaded path.
Signed-off-by: Frederic Weisbecker <[email protected]> Cc: Paul E. McKenney <[email protected]> Cc: Josh Triplett <[email protected]> Cc: Steven Rostedt <[email protected]> Cc: Mathieu Desnoyers <[email protected]> Cc: Lai Jiangshan <[email protected]> Cc: Joel Fernandes <[email protected]> --- kernel/rcu/tree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 804cf7dfff03..cc95419f6491 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3680,7 +3680,6 @@ void rcutree_migrate_callbacks(int cpu) raw_spin_unlock_rcu_node(my_rnp); /* irqs remain disabled. */ __call_rcu_nocb_wake(my_rdp, true, flags); } else { - rcu_nocb_unlock(my_rdp); /* irqs remain disabled. */ raw_spin_unlock_irqrestore_rcu_node(my_rnp, flags); } if (needwake) -- 2.25.0
