On 5/13/20 1:18 PM, Brendan Higgins wrote:
> On Wed, May 13, 2020 at 8:18 AM Heikki Krogerus
> <heikki.kroge...@linux.intel.com> wrote:
>>
>> In the function kobject_cleanup(), kobject_del(kobj) is
>> called before the kobj->release(). That makes it possible to
>> release the parent of the kobject before the kobject itself.
>>
>> To fix that, adding function __kboject_del() that does
>> everything that kobject_del() does except release the parent
>> reference. kobject_cleanup() then calls __kobject_del()
>> instead of kobject_del(), and separately decrements the
>> reference count of the parent kobject after kobj->release()
>> has been called.
>
> I was starting to wonder if anything else needed to happen with this. :-)
>
> Thanks for taking care of this!
>
>> Reported-by: Naresh Kamboju <naresh.kamb...@linaro.org>
>> Reported-by: kernel test robot <rong.a.c...@intel.com>
>> Fixes: 7589238a8cf3 ("Revert "software node: Simplify
>> software_node_release() function"")
>> Cc: Brendan Higgins <brendanhigg...@google.com>
>> Cc: Randy Dunlap <rdun...@infradead.org>
>> Suggested-by: "Rafael J. Wysocki" <raf...@kernel.org>
>> Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com>
>
> Didn't I and someone else test this?
>
> Either way, I will test this out in a little bit.
>
> Thanks!
>
Yes, I tested the earlier patch and acked it.
(using lib/test_printf.ko)
--
~Randy
