On Thu 14 May 10:01 PDT 2020, [email protected] wrote:

> From: Michael Srba <[email protected]>
> 
> This patch wires up display support on Samsung Galaxy A3 2015.
> 
> Signed-off-by: Michael Srba <[email protected]>
> 
> ---
>  .../qcom/msm8916-samsung-a2015-common.dtsi    | 44 +++++++++++++++
>  .../boot/dts/qcom/msm8916-samsung-a3u-eur.dts | 54 +++++++++++++++++++
>  2 files changed, 98 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi 
> b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> index af812f76e8be..2a64aa269f52 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> @@ -72,6 +72,24 @@ phy {
>                       };
>               };
>  
> +             mdss@1a00000 {
> +                     dsi@1a98000 {
> +                             #address-cells = <1>;
> +                             #size-cells = <0>;
> +
> +                             vdda-supply = <&pm8916_l2>;
> +                             vddio-supply = <&pm8916_l6>;
> +
> +                             pinctrl-names = "default", "sleep";
> +                             pinctrl-0 = <&mdss_default>;
> +                             pinctrl-1 = <&mdss_sleep>;
> +                     };
> +
> +                     dsi-phy@1a98300 {
> +                             vddio-supply = <&pm8916_l6>;
> +                     };
> +             };
> +
>               wcnss@a21b000 {
>                       status = "okay";
>               };
> @@ -172,6 +190,32 @@ pinconf {
>                       bias-disable;
>               };
>       };
> +
> +     pmx-mdss {
> +             mdss_default: mdss-default {
> +                     pinmux {
> +                             function = "gpio";
> +                             pins = "gpio25";
> +                     };
> +                     pinconf {
> +                             pins = "gpio25";
> +                             drive-strength = <8>;
> +                             bias-disable;
> +                     };
> +             };

Fyi, when you have a state with a single set of properties you don't
need the pinmux/pinconf level here, you can directly do:

                mdss_default: mdss-default {
                        pins = "gpio25";
                        function = "gpio";

                        drive-strength = <8>;
                        bias-disable;
                };


But this looks good, applied towards v5.8.

Regards,
Bjorn

Reply via email to