On Fri, May 15, 2020 at 01:47:40PM +0300, Serge Semin wrote:
> Since commit 22d48ad7bfac ("spi: dw: Add Elkhart Lake PSE DMA support")
> the spi-dw-mid.c module supports a platform DMA engine handling the DW APB
> SSI controller requests. Lets alter the DW SPI bindings file to accept the
> Rx and Tx DMA line specifiers.I'm wondering if these properties are implied by the SPI generic one? (forgive me if I'm not understanding all DT schema relations) Per se looks good. > Signed-off-by: Serge Semin <[email protected]> > Cc: Georgy Vlasov <[email protected]> > Cc: Ramil Zaripov <[email protected]> > Cc: Alexey Malahov <[email protected]> > Cc: Thomas Bogendoerfer <[email protected]> > Cc: Paul Burton <[email protected]> > Cc: Ralf Baechle <[email protected]> > Cc: Arnd Bergmann <[email protected]> > Cc: Allison Randal <[email protected]> > Cc: Andy Shevchenko <[email protected]> > Cc: Gareth Williams <[email protected]> > Cc: [email protected] > > --- > > Changelog v2: > - Revert the order of the DT changes: first add the DMA channels support, > then perform the binding file conversion. > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt > b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt > index 7a4702edf896..020e3168ee41 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.txt > @@ -23,6 +23,8 @@ Optional properties: > - num-cs : The number of chipselects. If omitted, this will default to 4. > - reg-io-width : The I/O register width (in bytes) implemented by this > device. Supported values are 2 or 4 (the default). > +- dmas : Phandle + identifiers of Tx and Rx DMA channels. > +- dma-names : Contains the names of the DMA channels. Must be "tx" and "rx". > > Child nodes as per the generic SPI binding. > > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko
