On Fri, May 15, 2020 at 01:47:46PM +0300, Serge Semin wrote:
> Seeing the "void *priv" member of the dw_spi data structure is unused
> let's remove it. The glue-layers can embed the DW APB SSI controller
> descriptor into their private data object. MMIO driver for instance
> already utilizes that design pattern.
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
>
> Signed-off-by: Serge Semin <sergey.se...@baikalelectronics.ru>
> Cc: Georgy Vlasov <georgy.vla...@baikalelectronics.ru>
> Cc: Ramil Zaripov <ramil.zari...@baikalelectronics.ru>
> Cc: Alexey Malahov <alexey.mala...@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbog...@alpha.franken.de>
> Cc: Paul Burton <paulbur...@kernel.org>
> Cc: Ralf Baechle <r...@linux-mips.org>
> Cc: Allison Randal <alli...@lohutok.net>
> Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com>
> Cc: Gareth Williams <gareth.williams...@renesas.com>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: linux-m...@vger.kernel.org
> Cc: devicet...@vger.kernel.org
>
> ---
>
> Changelog v2:
> - It's a new patch created as a result of more thorough driver study.
> ---
> drivers/spi/spi-dw.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
> index 60e9e430ce7b..b6ab81e0c747 100644
> --- a/drivers/spi/spi-dw.h
> +++ b/drivers/spi/spi-dw.h
> @@ -147,8 +147,6 @@ struct dw_spi {
> dma_addr_t dma_addr; /* phy address of the Data register */
> const struct dw_spi_dma_ops *dma_ops;
>
> - /* Bus interface info */
> - void *priv;
> #ifdef CONFIG_DEBUG_FS
> struct dentry *debugfs;
> #endif
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
