On Fri, May 15, 2020 at 09:28:37PM +0000, Luis Chamberlain wrote: > This makes use of the new module_firmware_crashed() to help > annotate when firmware for device drivers crash. When firmware > crashes devices can sometimes become unresponsive, and recovery > sometimes requires a driver unload / reload and in the worst cases > a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Derek Chickles <dchick...@marvell.com> > Cc: Satanand Burla <sbu...@marvell.com> > Cc: Felix Manlunas <fmanlu...@marvell.com> > Reviewed-by: Derek Chickles <dchick...@marvell.com> > Signed-off-by: Luis Chamberlain <mcg...@kernel.org> > --- > drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c > b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 66d31c018c7e..f18085262982 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param) > continue; > > WRITE_ONCE(oct->cores_crashed, true); > + module_firmware_crashed(); > other_oct = get_other_octeon_device(oct); > if (other_oct) > WRITE_ONCE(other_oct->cores_crashed, true); > -- > 2.26.2 > Acked-by: Rafael Aquini <aqu...@redhat.com>
- Re: [PATCH v2 13/15] ath6kl: use new module_firmware... Rafael Aquini
- [PATCH v2 07/15] cxgb4: use new module_firmware_crashed() Luis Chamberlain
- Re: [PATCH v2 07/15] cxgb4: use new module_firmware_... Rafael Aquini
- [PATCH v2 11/15] wimax/i2400m: use new module_firmware_cr... Luis Chamberlain
- Re: [PATCH v2 11/15] wimax/i2400m: use new module_fi... Rafael Aquini
- [PATCH v2 10/15] soc: qcom: ipa: use new module_firmware_... Luis Chamberlain
- Re: [PATCH v2 10/15] soc: qcom: ipa: use new module_... Rafael Aquini
- [PATCH v2 09/15] qed: use new module_firmware_crashed() Luis Chamberlain
- Re: [PATCH v2 09/15] qed: use new module_firmware_cr... Rafael Aquini
- [PATCH v2 06/15] liquidio: use new module_firmware_crashe... Luis Chamberlain
- Re: [PATCH v2 06/15] liquidio: use new module_firmwa... Rafael Aquini
- [PATCH v2 04/15] bnxt: use new module_firmware_crashed() Luis Chamberlain
- Re: [PATCH v2 04/15] bnxt: use new module_firmware_c... Rafael Aquini
- Re: [PATCH v2 04/15] bnxt: use new module_firmware_c... Vasundhara Volam
- [PATCH v2 14/15] brcm80211: use new module_firmware_crash... Luis Chamberlain
- Re: [PATCH v2 14/15] brcm80211: use new module_firmw... Rafael Aquini
- [PATCH v2 05/15] bna: use new module_firmware_crashed() Luis Chamberlain
- Re: [PATCH v2 05/15] bna: use new module_firmware_cr... Rafael Aquini
- [PATCH v2 01/15] taint: add module firmware crash taint s... Luis Chamberlain
- Re: [PATCH v2 01/15] taint: add module firmware cras... Rafael Aquini