Hello Greg, > On Mon, May 18, 2020 at 09:33:57AM +0200, Gregory CLEMENT wrote: >> Hello Jiri, >> >> > On 12. 05. 20, 13:53, Gregory CLEMENT wrote: >> >> Use appropriate print helpers for debug messages. >> >> >> >> Signed-off-by: Gregory CLEMENT <[email protected]> >> >> --- >> >> drivers/tty/n_gsm.c | 14 ++------------ >> >> 1 file changed, 2 insertions(+), 12 deletions(-) >> >> >> >> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c >> >> index d77ed82a4840..67c8f8173023 100644 >> >> --- a/drivers/tty/n_gsm.c >> >> +++ b/drivers/tty/n_gsm.c >> >> @@ -504,18 +504,8 @@ static void gsm_print_packet(const char *hdr, int >> >> addr, int cr, >> >> else >> >> pr_cont("(F)"); >> >> >> >> - if (dlen) { >> >> - int ct = 0; >> >> - while (dlen--) { >> >> - if (ct % 8 == 0) { >> >> - pr_cont("\n"); >> >> - pr_debug(" "); >> >> - } >> >> - pr_cont("%02X ", *data++); >> >> - ct++; >> >> - } >> >> - } >> >> - pr_cont("\n"); >> >> + if (dlen) >> > >> > This test is superfluous. print_hex_dump_* won't write anything when >> > zero length is passed to it. >> >> As I will send a v3 due to the issue found on the last patch, I am also >> going to fix this. > > Ugh, as I already applied this series, should I just revert them all, or > are you going to send fix-ups on top of what I have applied instead?
I was about to send a new series, but I can just send fix-ups. It's up to you. Gregory > > thanks, > > greg k-h -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
