Hi Andrew, On 5/15/20 8:23 PM, Andrew Morton wrote: > On Sat, 18 Apr 2020 21:19:06 +0100 Dmitry Safonov <d...@arista.com> wrote: > >> Currently, the log-level of show_stack() depends on a platform >> realization. It creates situations where the headers are printed with >> lower log level or higher than the stacktrace (depending on >> a platform or user). >> >> Furthermore, it forces the logic decision from user to an architecture >> side. In result, some users as sysrq/kdb/etc are doing tricks with >> temporary rising console_loglevel while printing their messages. >> And in result it not only may print unwanted messages from other CPUs, >> but also omit printing at all in the unlucky case where the printk() >> was deferred. >> >> Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems >> an easier approach than introducing more printk buffers. >> Also, it will consolidate printings with headers. >> >> Introduce show_stack_loglvl(), that eventually will substitute >> show_stack(). > > The csky code has changed a lot in linux-next due to 18c07d23da5a > ("csky: Fixup calltrace panic"). I redid this patch as below. Can we > please review and test?
The result looks good to me, thanks for the rebase! Thanks, Dmitry