Hi James, On 5/18/2020 6:19 AM, James Morse wrote: > diff --git a/arch/x86/kernel/cpu/resctrl/internal.h > b/arch/x86/kernel/cpu/resctrl/internal.h > index dd51e23e346b..0b288b6fefd9 100644 > --- a/arch/x86/kernel/cpu/resctrl/internal.h > +++ b/arch/x86/kernel/cpu/resctrl/internal.h > @@ -370,6 +370,7 @@ struct rdt_cache { > * struct rdt_membw - Memory bandwidth allocation related data > * @min_bw: Minimum memory bandwidth percentage user can request > * @bw_gran: Granularity at which the memory bandwidth is allocated > + * @arch_needs_linear: True if we can't configure non-linear resources > * @delay_linear: True if memory B/W delay is in linear scale > * @mba_sc: True if MBA software controller(mba_sc) is enabled > * @mb_map: Mapping of memory B/W percentage to memory B/W delay > @@ -378,6 +379,7 @@ struct rdt_membw { > u32 min_bw; > u32 bw_gran; > u32 delay_linear; > + bool arch_needs_linear; > bool mba_sc; > u32 *mb_map; > }; >
Sorry, I just noticed this while rebasing our respective changes to this area ... could the comments be in the same order as the fields in the struct? Reinette