Hi Bhaumik,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20200519]
[cannot apply to linus/master v5.7-rc6 v5.7-rc5 v5.7-rc4 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Bug-fixes-and-bootup-and-shutdown-improvements/20200520-083400
base:    fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 
3393cc4cebf9969db94dc424b7a2b6195589c33b)
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <l...@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/bus/mhi/core/main.c:397:8: error: implicit declaration of function 
>> 'mhi_is_active' [-Werror,-Wimplicit-function-declaration]
if (!mhi_is_active(mhi_cntrl)) {
^
1 error generated.

vim +/mhi_is_active +397 drivers/bus/mhi/core/main.c

   371  
   372  irqreturn_t mhi_intvec_threaded_handler(int irq_number, void *priv)
   373  {
   374          struct mhi_controller *mhi_cntrl = priv;
   375          struct device *dev = &mhi_cntrl->mhi_dev->dev;
   376          enum mhi_state state = MHI_STATE_MAX;
   377          enum mhi_pm_state pm_state = 0;
   378          enum mhi_ee_type ee = 0;
   379          bool handle_rddm = false;
   380  
   381          write_lock_irq(&mhi_cntrl->pm_lock);
   382          if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {
   383                  write_unlock_irq(&mhi_cntrl->pm_lock);
   384                  goto exit_intvec;
   385          }
   386  
   387          state = mhi_get_mhi_state(mhi_cntrl);
   388          ee = mhi_cntrl->ee;
   389          mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
   390          dev_dbg(dev, "local ee:%s device ee:%s dev_state:%s\n",
   391                  TO_MHI_EXEC_STR(mhi_cntrl->ee), TO_MHI_EXEC_STR(ee),
   392                  TO_MHI_STATE_STR(state));
   393  
   394           /* If device supports RDDM don't bother processing SYS error */
   395          if (mhi_cntrl->rddm_image) {
   396                  /* host may be performing a device power down already */
 > 397                  if (!mhi_is_active(mhi_cntrl)) {
   398                          write_unlock_irq(&mhi_cntrl->pm_lock);
   399                          goto exit_intvec;
   400                  }
   401  
   402                  if (mhi_cntrl->ee == MHI_EE_RDDM && mhi_cntrl->ee != 
ee) {
   403                          /* prevent clients from queueing any more 
packets */
   404                          pm_state = mhi_tryset_pm_state(mhi_cntrl,
   405                                                         
MHI_PM_SYS_ERR_DETECT);
   406                          if (pm_state == MHI_PM_SYS_ERR_DETECT)
   407                                  handle_rddm = true;
   408                  }
   409  
   410                  write_unlock_irq(&mhi_cntrl->pm_lock);
   411  
   412                  if (handle_rddm) {
   413                          dev_err(dev, "RDDM event occurred!\n");
   414                          mhi_cntrl->status_cb(mhi_cntrl, MHI_CB_EE_RDDM);
   415                          wake_up_all(&mhi_cntrl->state_event);
   416                  }
   417                  goto exit_intvec;
   418          }
   419  
   420          if (state == MHI_STATE_SYS_ERR) {
   421                  dev_dbg(dev, "System error detected\n");
   422                  pm_state = mhi_tryset_pm_state(mhi_cntrl,
   423                                                 MHI_PM_SYS_ERR_DETECT);
   424          }
   425  
   426          write_unlock_irq(&mhi_cntrl->pm_lock);
   427  
   428          if (pm_state == MHI_PM_SYS_ERR_DETECT) {
   429                  wake_up_all(&mhi_cntrl->state_event);
   430  
   431                  /* For fatal errors, we let controller decide next step 
*/
   432                  if (MHI_IN_PBL(ee))
   433                          mhi_cntrl->status_cb(mhi_cntrl, 
MHI_CB_FATAL_ERROR);
   434                  else
   435                          mhi_pm_sys_err_handler(mhi_cntrl);
   436          }
   437  
   438  exit_intvec:
   439  
   440          return IRQ_HANDLED;
   441  }
   442  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to