On Thu, May 21, 2020 at 11:14:38AM +0100, Will Deacon wrote: > On Thu, May 21, 2020 at 10:26:27AM +0100, Sudeep Holla wrote: > > On Thu, May 21, 2020 at 10:17:39AM +0100, Will Deacon wrote: > > > On Thu, May 21, 2020 at 11:06:23AM +0200, Arnd Bergmann wrote: > > > > On Thu, May 21, 2020 at 10:11 AM Sudeep Holla <[email protected]> > > > > wrote: > > > > > /me confused. Do you need the fix for this warning or you are happy > > > > > to ignore? > > > > > > > > I want a fix for that, as I hope we can eventually turn this warning on > > > > by > > > > default and stop playing whack-a-mole when they come up. Most of these > > > > warnings are harmless, but occasionally the prototypes don't match > > > > exactly > > > > and cause real bugs depending on the configuration, and ensuring both > > > > sides include a common header file is an easy way to make it work > > > > more reliably. > > > > > > > > Note that the warning should come up for either W=1 or C=1, and I also > > > > think that > > > > new code should generally be written sparse-clean and have no warnings > > > > with > > > > 'make C=1' as a rule. > > > > > > Fair enough. Is anybody working on a tree-wide sweep for this, like we've > > > done for other things such as zero-length arrays? If so, I can start > > > enforcing this in the arch code as well (I haven't been so far, even > > > though > > > I do run sparse on every commit). > > > > > > Anyway, I've dropped the last patch from the branch, and we can put a fix > > > for the missing prototype on top. > > > > > > > Thanks Will, sorry for the trouble. Though I can send the fix for the > > missing prototype right away, I would like to get my clang setup working > > as an opportunity. clang-8 that I have is failing vanilla v5.7-rc6 > > when expanding arm_smccc_1_1_* > > No trouble at all, really. I also saw this from Nathan the other day, which > may help you get up and running with clang: > > https://lore.kernel.org/r/20200520024736.GA854786@ubuntu-s3-xlarge-x86 >
Thanks for the link, I will try some other time(may be next time I run into clang issue 😄). Anyway upgrading to clang-11 fixed the build issue. I will soon post the patch for missing prototype. -- Regards, Sudeep
