Hi Daniel, Thank you for the patch.
On Mon, May 18, 2020 at 10:16:46PM +0200, Daniel Gomez wrote: > Select DRM_KMS_HELPER dependency. > > Build error when DRM_KMS_HELPER is not selected: > > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd48): undefined reference to > `drm_atomic_helper_bridge_duplicate_state' > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd50): undefined reference to > `drm_atomic_helper_bridge_destroy_state' > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xd70): undefined reference to > `drm_atomic_helper_bridge_reset' > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xdc8): undefined reference to > `drm_atomic_helper_connector_reset' > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xde0): undefined reference to > `drm_helper_probe_single_connector_modes' > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xe08): undefined reference to > `drm_atomic_helper_connector_duplicate_state' > drivers/gpu/drm/rcar-du/rcar_lvds.o:(.rodata+0xe10): undefined reference to > `drm_atomic_helper_connector_destroy_state' > > Signed-off-by: Daniel Gomez <dag...@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> and taken in my tree for v5.9. If you think it should get in v5.8 as a fix, I can do so as well, could you then provide a Fixes: tag ? > --- > drivers/gpu/drm/rcar-du/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > index 0919f1f159a4..f65d1489dc50 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -31,6 +31,7 @@ config DRM_RCAR_DW_HDMI > config DRM_RCAR_LVDS > tristate "R-Car DU LVDS Encoder Support" > depends on DRM && DRM_BRIDGE && OF > + select DRM_KMS_HELPER > select DRM_PANEL > select OF_FLATTREE > select OF_OVERLAY -- Regards, Laurent Pinchart
