On Sun, May 24, 2020 at 04:22:14PM -0700, Fangrui Song wrote: > > Probably worth mentioning that this works around GNU ld<2.35
Thanks, I'll add that in v2. > > > This commit fixing https://sourceware.org/bugzilla/show_bug.cgi?id=25754 > also fixed the bug. (Just verified that both 2.24 and 2.34 have the bug. > binutils-gdb HEAD (future 2.35) is good.) > > % cat a.s > pushl $z_input_len > % cat b.s > .globl z_input_len > z_input_len = 0xb612 > % gcc -m32 -c a.s b.s > % ld.bfd -m elf_i386 -pie a.o b.o # has an incorrect R_386_RELATIVE before > binutils 2.35 > > > Reviewed-by: Fangrui Song <[email protected]>

