On 05/25, Chao Yu wrote:
> On 2020/5/25 11:56, Jaegeuk Kim wrote:
> > Shutdown test is somtimes hung, since it keeps trying to flush dirty node
> > pages
>
> IMO, for umount case, we should drop dirty reference and dirty pages on
> meta/data
> pages like we change for node pages to avoid potential dead loop...
I believe we're doing for them. :P
>
> Thanks,
>
> > in an inifinite loop. Let's drop dirty pages at umount in that case.
> >
> > Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
> > ---
> > v3:
> > - fix wrong unlock
> >
> > v2:
> > - fix typos
> >
> > fs/f2fs/node.c | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> > index e632de10aedab..e0bb0f7e0506e 100644
> > --- a/fs/f2fs/node.c
> > +++ b/fs/f2fs/node.c
> > @@ -1520,8 +1520,15 @@ static int __write_node_page(struct page *page, bool
> > atomic, bool *submitted,
> >
> > trace_f2fs_writepage(page, NODE);
> >
> > - if (unlikely(f2fs_cp_error(sbi)))
> > + if (unlikely(f2fs_cp_error(sbi))) {
> > + if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) {
> > + ClearPageUptodate(page);
> > + dec_page_count(sbi, F2FS_DIRTY_NODES);
> > + unlock_page(page);
> > + return 0;
> > + }
> > goto redirty_out;
> > + }
> >
> > if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
> > goto redirty_out;
> >
