Hi Hinko, On Fri, Oct 12, 2007 at 02:56:27PM +0200, [EMAIL PROTECTED] wrote: > Hi, > > While testing the mcs7780 based IrDA USB dongle I've stumbled upon > memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in > irlmp_register_link and should probably be freed in irlmp_unregister_link(). > > Signed-off-by: Hinko Kocevar <[EMAIL PROTECTED]> > > Best regards, > Hinko > > ---- > >
> --- linux-2.6.23/net/irda/irlmp.c.orig 2007-10-12 14:05:17.000000000 > +0200 > +++ linux-2.6.23/net/irda/irlmp.c 2007-10-12 14:05:41.000000000 +0200 > @@ -353,6 +353,7 @@ void irlmp_unregister_link(__u32 saddr) > /* Final cleanup */ > del_timer(&link->idle_timer); > link->magic = 0; > + hashbin_delete(link->lsaps, (FREE_FUNC) kfree); Good catch, but I think the right fix sould be: + hashbin_delete(link->lsaps, (FREE_FUNC) __irlmp_close_lsap); and I'll forward it. Thanks a lot. Cheers, Samuel. > kfree(link); > } > } > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > irda-users mailing list > [EMAIL PROTECTED] > http://lists.sourceforge.net/lists/listinfo/irda-users - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
