Rob, Could you please pay attention to this patch? The patchset review procedure is nearly over, while the DT part is only partly reviewed by you.
Thanks -Sergey On Wed, May 27, 2020 at 06:30:38PM +0300, Serge Semin wrote: > Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding. Even > though the corresponding node is supposed to be a child of the Baikal-T1 > System Controller, its reg property is left required for compatibility. > > Signed-off-by: Serge Semin <sergey.se...@baikalelectronics.ru> > Cc: Alexey Malahov <alexey.mala...@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbog...@alpha.franken.de> > Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> > Cc: Mika Westerberg <mika.westerb...@linux.intel.com> > Cc: linux-m...@vger.kernel.org > > --- > > Changelog v2: > - Make the reg property being optional if it's Baikal-T1 System I2C DT > node. > > Changelog v3: > - Get back the reg property being mandatory even if it's Baikal-T1 System > I2C DT node. Rob says it has to be in the DT node if there is a > dedicated registers range in the System Controller registers space. > --- > Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > index 101d78e8f19d..8c9b3db1b1b8 100644 > --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > @@ -31,6 +31,8 @@ properties: > items: > - const: mscc,ocelot-i2c > - const: snps,designware-i2c > + - description: Baikal-T1 SoC System I2C controller > + const: baikal,bt1-sys-i2c > > reg: > minItems: 1 > -- > 2.26.2 >
