On Sun, 14 Oct 2007, Christoph Hellwig wrote: > > Commit 6c5d5238 introduced a set_dumpable() function that replaced the > > direct access to mm_struct->dumpable. I don't think there is any > > reason to restrict this function to EXPORT_SYMBOL_GPL() -- previously > > any module could modify current->mm->dumpable without any > > resitrictions, so it makes a little sense to turn this into 'internal > > interface' at once. > Nack, the just shouldn't do such things at all. I start to get really > sick of patches adding random exports everywhere.
I actually don't care that much whether this is merged or not. In fact the function itself is pretty trivial and standalone, so any 3rd party module willing to modify current->mm->flags can just reimplement it line-by-line themselves without breaking the license anyway ... My main point here was that we should probably better document somewhere what are the intended usage scenarios for EXPORT_SYMBOL() vs. EXPORT_SYMBOL_GPL(). "Really internal interface" seems a little bit vague to me. -- Jiri Kosina SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/