[RFC PATCH] checkpatch: check for trivial sizeofs

[Denis Efremov]

sizeof(char) and its variations in most cases doesn't make code more clear.
It only makes code wordy.

Signed-off-by: Denis Efremov <efre...@linux.com>
---
 scripts/checkpatch.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index eac40f0abd56..9dd338b125d2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6045,6 +6045,13 @@ sub process {
                        }
                }
 
+# check for trivial sizeof(char) == 1
+               if ($line =~ 
/\bsizeof\s*\(\s*((?:(?:un)?signed\s+)?char|(?:__)?u8|u?int8_t|[us]?byte(?:_t)?)\s*\)/)
 {
+                       my $byte = $1;
+                       CHK("SIZEOF_TRIVIAL",
+                            "redundant sizeof($byte) == 1 \n" . $herecurr);
+               }
+
 # check for struct spinlock declarations
                if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) {
                        WARN("USE_SPINLOCK_T",
-- 
2.26.2