On Sun, 07 Oct 2007 22:49:00 +1000 Gilles Gigan <[EMAIL PROTECTED]> wrote:
> Andrey Panin wrote: > >> +#ifdef CONFIG_WATCHDOG_NOWAYOUT > >> +#define NOWAYOUT 1 > >> +#else > >> +#define NOWAYOUT 0 > >> +#endif > >> +static int nowayout = NOWAYOUT; > > > > You don't need this #ifdef crap. Just use WATCHDOG_NOWAYOUT instead. > > done > > > >> + if ((_IOC_DIR(cmd) & _IOC_READ) && > >> + (!access_ok(VERIFY_WRITE, (void __user *)arg, _IOC_SIZE(cmd)))) > >> + return -EFAULT; > >> + if ((_IOC_DIR(cmd) & _IOC_WRITE) && > >> + (!access_ok(VERIFY_READ, (void __user *)arg, _IOC_SIZE(cmd)))) > >> + return -EFAULT; > > > > Is this really needed ? > > removed > > Signed-off-by: Gilles Gigan <[EMAIL PROTECTED]> > --- > > diff -uprN -X linux-2.6.23-rc9/Documentation/dontdiff > linux-2.6.23-rc9/drivers/char/watchdog/Kconfig > linux-2.6.23-rc9-dirty/drivers/char/watchdog/Kconfig Could you please send a new version of this patch which has a changelog, isn't space-stuffed and isn't wordwrapped? Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
