On Mon, Jun 1, 2020 at 6:09 AM Jiri Olsa <jo...@redhat.com> wrote: > > On Mon, Jun 01, 2020 at 12:55:44AM -0700, Ian Rogers wrote: > > On Sun, May 24, 2020 at 3:43 PM Jiri Olsa <jo...@kernel.org> wrote: > > > > > > Adding new test that process metrics code and checks > > > the expected results. Starting with easy ipc metric. > > > > > > Signed-off-by: Jiri Olsa <jo...@kernel.org> > > > > Acked-by: Ian Rogers <irog...@google.com> > > > > I wonder if there's a better organization with testing in > > pmu-events.c, expr.c and now parse-metric.c. > > hum, so > - expr.c is testing core interface, > - parse-metric is testing specific metric processing from > parsing to final ratio > - pmu-events.c is testing pmu events aliases and parsing of > all the metrics > > pmu-events.c is testing both pmu events and metrics, > but I think it fits in the way it's done together
Agreed, it makes following this a little bit of a challenge. When I did the parsing in pmu-events I'd originally done it in expr.c for example. Perhaps if there were a parse-metric in tools/perf/util then things would align better as well. Just thinking out loud :-) Thanks, Ian > jirka >
