On Fri, May 15, 2020 at 06:59:03PM +0900, Kunihiko Hayashi wrote: > Even if phy driver doesn't probe, the error message can't be distinguished > from other errors. This displays error message caused by the phy driver > explicitly. > > Signed-off-by: Kunihiko Hayashi <[email protected]> > --- > drivers/pci/controller/dwc/pcie-uniphier.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c > b/drivers/pci/controller/dwc/pcie-uniphier.c > index 493f105..7ae9688 100644 > --- a/drivers/pci/controller/dwc/pcie-uniphier.c > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c > @@ -468,8 +468,11 @@ static int uniphier_pcie_probe(struct platform_device > *pdev) > return PTR_ERR(priv->rst); > > priv->phy = devm_phy_optional_get(dev, "pcie-phy"); > - if (IS_ERR(priv->phy)) > - return PTR_ERR(priv->phy); > + if (IS_ERR(priv->phy)) { > + ret = PTR_ERR(priv->phy); > + dev_err(dev, "Failed to get phy (%d)\n", ret);
This will print an error on EPROBE_DEFERRED which isn't an error. > + return ret; > + } > > platform_set_drvdata(pdev, priv); > > -- > 2.7.4 >
