Markus Elfring <[email protected]> writes: >> Please just remove the message instead, it's a tiny allocation that's >> unlikely to ever fail, and the caller will print an error anyway. > > How do you think about to take another look at a previous update suggestion > like the following? > > powerpc/nvram: Delete three error messages for a failed memory allocation > https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/ > https://lore.kernel.org/linuxppc-dev/[email protected]/ > https://lore.kernel.org/patchwork/patch/752720/ > https://lkml.org/lkml/2017/1/19/537
That deleted the messages from nvram_scan_partitions(), but neither of the callers of nvram_scan_paritions() check its return value or print anything if it fails. So removing those messages would make those failures silent which is not what we want. cheers
