> -----Original Message----- > From: Takashi Iwai <ti...@suse.de> > Sent: Wednesday, June 3, 2020 8:24 PM > To: Steve Lee <steves....@maximintegrated.com> > Cc: lgirdw...@gmail.com; broo...@kernel.org; pe...@perex.cz; > ti...@suse.com; ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com; shumi...@realtek.com; > srinivas.kandaga...@linaro.org; k...@kernel.org; dmur...@ti.com; > jack...@realtek.com; nuno...@analog.com; linux-kernel@vger.kernel.org; > alsa-de...@alsa-project.org; ryan.lee.ma...@gmail.com; Ryan Lee > <ryans....@maximintegrated.com>; steves.lee.ma...@gmail.com > Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw > loading > > EXTERNAL EMAIL > > > > On Wed, 03 Jun 2020 13:18:19 +0200, > Steve Lee wrote: > > > > @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component > *component) > > > > /* Dsm Setting */ > > regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94); > > - regmap_write(max98390->regmap, DSMIG_EN, 0x19); > > Is this change intentional? > It wasn't mentioned in the patch description.
It should be another change. I will re-send the patch. > > > thanks, > > Takashi