mccic_register() forgets to cleanup the notifier in its error handler.
mccic_shutdown() also misses calling v4l2_async_notifier_cleanup().
Add the missed calls to fix them.

Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the 
sensor")
Signed-off-by: Chuhong Yuan <hsleste...@gmail.com>
---
Changes in v2:
  - Also add v4l2_async_notifier_cleanup() for mccic_shutdown().
  - Modify description.

 drivers/media/platform/marvell-ccic/mcam-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c 
b/drivers/media/platform/marvell-ccic/mcam-core.c
index 09775b6624c6..326e79b8531c 100644
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
 out:
        v4l2_async_notifier_unregister(&cam->notifier);
        v4l2_device_unregister(&cam->v4l2_dev);
+       v4l2_async_notifier_cleanup(&cam->notifier);
        return ret;
 }
 EXPORT_SYMBOL_GPL(mccic_register);
@@ -1961,6 +1962,7 @@ void mccic_shutdown(struct mcam_camera *cam)
        v4l2_ctrl_handler_free(&cam->ctrl_handler);
        v4l2_async_notifier_unregister(&cam->notifier);
        v4l2_device_unregister(&cam->v4l2_dev);
+       v4l2_async_notifier_cleanup(&cam->notifier);
 }
 EXPORT_SYMBOL_GPL(mccic_shutdown);
 
-- 
2.26.2

Reply via email to