In message <[EMAIL PROTECTED]>, Andy Whitcroft writes: > On Sat, Oct 13, 2007 at 02:35:12PM -0400, Erez Zadok wrote: > > In message <[EMAIL PROTECTED]>, Andy Whitcroft writes: > > > On Fri, Oct 12, 2007 at 03:26:54PM -0400, Mike D. Day wrote: > > > > Fix line number reporting when checking source files (as opposed to > > > > patches) > > > > > > > > Signed-off-by: Mike D. Day <[EMAIL PROTECTED]> > > > > > > Sorry you've had to fix this about 4 times, mostly because of ongoing > > > changes, and slow replication getting in the way. I've applied this > > > and you should find it in -next when replication hits. md5sum is > > > below of the version with it in, so you can make sure you've got > > > the right one. > > > > > > 54f053c50265e44a6041e3147dc66a69 checkpatch.pl > > > > > > -apw > > > > Andy, I've tested the --emacs feature in the above latest > > checkpatch.pl-next. Below is a patch that completes the functionality of > > the --emacs option: it ensures that only the cc-style error messages are > > printed, no extra context lines or caret lines, no extra newlines, etc. > > Although this patch changes every call to a message-producing function, it > > is a trivial change, and I believe it's the cleanest way to handle the > > separation between the terse cc-style messages and the verbose default > > messages. With this patch, I can finally test a single source file as > > follows: > > > > $ ./scripts/checkpatch.pl -q -q --emacs --file path/name/to/file > > Ok I don't understand why the rest of the lines are a problem? At least > with emacs the extra context lines are just ignored right? Are you > trying to use this as a summary?
Andy, I'm trying to minimize excess stuff that's not necessarily useful for everyone, and to match what is done elsewhere. For example, I don't need those extra newlines and find them a distraction. And if get an error message such as "put a space after a comma", I don't really need a caret sign to point to the exact char in the line where it is. When g/cc prints out errors from a compile, the errors are one per line, w/o any additional context lines, caret markers, newlines, etc. grep -n does the same (also useful inside emacs). So I'm just asking for a way to have the same terse format. If you feel that the extra info is still useful for some people, then can you please provide a way for some people like me to turn off the extra lines (pass a third -q, or a --terse option)? > -apw Thanks, Erez. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/