On 05/06/2020 04:12, Navid Emamdoost wrote: > Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. > > Signed-off-by: Navid Emamdoost <[email protected]> > --- > drivers/pci/controller/pci-tegra.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/pci-tegra.c > b/drivers/pci/controller/pci-tegra.c > index 3e64ba6a36a8..3d4b448fd8df 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -2712,6 +2712,7 @@ static int tegra_pcie_probe(struct platform_device > *pdev) > err = pm_runtime_get_sync(pcie->dev); > if (err < 0) { > dev_err(dev, "fail to enable pcie controller: %d\n", err); > + pm_runtime_put_sync(pcie->dev); > goto teardown_msi; > }
Same thing for this patch, there is already a put in the error path and so it is not necessary to add the put call here. Just update the goto label. Jon -- nvpublic
