> From: Denis Efremov <efre...@linux.com>
> Sent: Friday, June 5, 2020 1:00 AM
> To: Dexuan Cui <de...@microsoft.com>; Michael Kelley
> <mikel...@microsoft.com>
> Cc: Denis Efremov <efre...@linux.com>; James E . J . Bottomley
> <j...@linux.ibm.com>; Martin K . Petersen <martin.peter...@oracle.com>;
> linux-hyp...@vger.kernel.org; Linux SCSI List <linux-s...@vger.kernel.org>;
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: [PATCH] scsi: storvsc: Remove memset before memory freeing in
> storvsc_suspend()
>
> Remove memset with 0 for stor_device->stor_chns in storvsc_suspend()
> before the call to kfree() as the memory contains no sensitive information.
>
> Fixes: 56fb10585934 ("scsi: storvsc: Add the support of hibernation")
> Suggested-by: Dexuan Cui <de...@microsoft.com>
> Signed-off-by: Denis Efremov <efre...@linux.com>
> ---
> drivers/scsi/storvsc_drv.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 072ed8728657..2d90cddd8ac2 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -2035,9 +2035,6 @@ static int storvsc_suspend(struct hv_device
> *hv_dev)
>
> vmbus_close(hv_dev->channel);
>
> - memset(stor_device->stor_chns, 0,
> - num_possible_cpus() * sizeof(void *));
> -
> kfree(stor_device->stor_chns);
> stor_device->stor_chns = NULL;
>
> --
Denis, thank you for fixing this!
Reviewed-by: Dexuan Cui <de...@microsoft.com>
